fix: FS- beta treadmills discover only FTMS service (0x1826) - #4815
Open
cagnulein wants to merge 1 commit into
Open
fix: FS- beta treadmills discover only FTMS service (0x1826)#4815cagnulein wants to merge 1 commit into
cagnulein wants to merge 1 commit into
Conversation
Devices starting with "FS-" and containing "(beta)" in the name were triggering full BLE service discovery, which caused issues. Limit service discovery to the FTMS service (0x1826) only for these devices, matching the existing workaround used for DOMYOS-TC. Fixes #4808 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4808
Devices handled by
horizontreadmillthat start withFS-and contain(beta)in the name were performing a full BLE service discovery, which could cause connection issues. This PR limits discovery to the FTMS service (0x1826) only for these devices.FS_BETA_TREADMILLflag inhorizontreadmill.hdeviceDiscovered()when the device name starts with"FS-"and contains"(beta)"serviceScanDone(), skip all services except0x1826whenFS_BETA_TREADMILLis true (same pattern already used for DOMYOS-TC devices)Test plan
FS-and contains(beta)and verify only service0x1826is discovered in the debug logFS-device (without(beta)) and verify full service discovery still happenshorizontreadmill🤖 Generated with Claude Code